Skip to content

Remove point-at-infinity filter in g1_lincomb_fast#588

Merged
asn-d6 merged 1 commit intoethereum:mainfrom
jtraglia:remove-zero-point-filter
Aug 1, 2025
Merged

Remove point-at-infinity filter in g1_lincomb_fast#588
asn-d6 merged 1 commit intoethereum:mainfrom
jtraglia:remove-zero-point-filter

Conversation

@jtraglia
Copy link
Member

Now that blst properly handles this, we can remove this filtering 🙂

See: supranational/blst@ae643ba

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This feels much cleaner.

(Perhaps it's time to also remove the second @remark in the function.)

@jtraglia
Copy link
Member Author

Perhaps it's time to also remove the second @remark in the function.

I'll follow up with another PR after the current audit is complete :)

@asn-d6 asn-d6 merged commit fb66f79 into ethereum:main Aug 1, 2025
50 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants